[
https://issues.apache.org/jira/browse/HADOOP-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661496#action_12661496
]
Sreekanth Ramakrishnan commented on HADOOP-4831:
------------------------------------------------
ControlledMapReduceJob:
Remove unncessary import statement:
import org.apache.hadoop.mapred.lib.NullOutputFormat
Can you remove the import statement:
import
org.apache.hadoop.mapred.ControlledMapReduceJob.ControlledMapReduceJobRunner.ControlledOutputCommitter
Instead we can rewrite line 503 to :
conf.setOutputCommitter(ControlledMapReduceJobRunner.ControlledOutputCommitter.class);
Minor nit typo in javadoc comment for haveAllTasksFinished(JobInProgress jip,
boolean isMap)
TestJobInitialization:
Please document the class TestJobInitialization by marking that job
initialization testing is done by controlling setup task of a job, for test
cases within TestCapacityScheduler test job initalization by controlling
schedulers assign task and monitoring run queue of scheduler.
Please document the methods : waitTillOnlyNJobsAreInitialized,
getNonRunningInitalizedJobs
Method waitTillOnlyNJobsAreInitalized does two things i.e. it waits till n jobs
are initialized then sleeps for one poller cycle and checks if the actual
number of initialized jobs are maintained in steady state. Can you please
document this?
Are you planning to add test case to check if Job initialization works properly
in case of job failures? Also case where Job initialization across two queues
happen independent fashion?
> Have end to end tests based on MiniMRCluster to verify the correct behaviour
> of job initialization.
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-4831
> URL: https://issues.apache.org/jira/browse/HADOOP-4831
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Vinod K V
> Assignee: Vinod K V
> Attachments: HADOOP-4831-20081230-git-final.txt,
> HADOOP-4831-20090107-svn-1.txt
>
>
> Write tests to verify that the right number of jobs in the right order are
> initialized and that the limits on the number of jobs that can stay
> initialized at any time are honoured.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
