[ 
https://issues.apache.org/jira/browse/HADOOP-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665319#action_12665319
 ] 

Vivek Ratan commented on HADOOP-5048:
-------------------------------------

bq. The pseudo code written as comments in the method is going to be hard to 
maintain

I had asked Sreekanth to put the algorithm logic in the comments. I feel it's 
important to do that because the actual code can be a bit different. You may 
combine some if statements, or move code around to make it better performing, 
perhaps, and this often leads to harder readability. The comments indicate what 
the logic is like, the code may implement it differently. The comments helped 
me understand what was going on, much more than the code (and accompanying 
logic) did. That said, the 'pseudo code' or comments need to be accurate. 
Perhaps they can be reworded a bit to read better. Let me work with Sreekanth 
to make them better. 

> Sometimes job is still displayed in jobqueue_details page for long time after 
> job was killed.
> ---------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-5048
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5048
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>            Reporter: Karam Singh
>            Assignee: Sreekanth Ramakrishnan
>         Attachments: HADOOP-5048-1.patch, HADOOP-5048-2.patch
>
>
> When I tried kill all running job, I noticed that were two jobs were listed 
> on jobqueue_details.jsp page page as well as they were also listed under 
> failed job on jobtracker.jsp page.
> When I checked status of each that was displayed "killed" and Cleanup task 
> status as "Successful", but both jobs were also being on jobqueue_details.jsp 
> page for longtime e.g up to 10 -15 mins after I restarted JobTracker.
> Before killing the jobs, status of both jobs was running and no task of from 
> them was scheduled.
> I noticed this behavior on 3 different occasions. But is this random, not 
> always reproducible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to