[ 
https://issues.apache.org/jira/browse/HADOOP-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665976#action_12665976
 ] 

Hairong Kuang commented on HADOOP-5009:
---------------------------------------

     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no tests are needed for 
this patch.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
     [exec]
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath 
integrity.

ant test-core fails only TestMapReduceLocal which is a known issue.

> DataNode#shutdown sometimes leaves data block scanner verification log 
> unclosed
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-5009
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5009
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.17.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: 0.19.1
>
>         Attachments: blockScannerFd.patch, blockScannerFd1.patch
>
>
> When datanode gets shutdown by calling DataNode#shutdown, it occasionally 
> leaves the data block scanner verification log unclosed. There are two 
> possible causes:
> 1. DataNode does not wait until block scanner thread to exit.
> 2. DataBlockScanner does not guarantee that the verification log is closed if 
> the scanner is interrupted. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to