[ 
https://issues.apache.org/jira/browse/HADOOP-4944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667297#action_12667297
 ] 

Steve Loughran commented on HADOOP-4944:
----------------------------------------

As someone who works in CM, I clearly think that being able to include stuff is 
a handy way to deal with scale. But if you treat every .xml file as toplevel, 
dont forget to include test cases that 
* have an import of yourself
* import file A.xml that imports B.xml that imports A.xml
* include inconsistent (name,value) declarations
* import file A.xml that imports B.xml that then imports a nonexistent file 
(try and have the error message helpfile here)
* tries to do property expansion to set the path of the include

You dont have to support these, property expansion in particular. But get those 
tests together to make sure that whatever behaviour you have matches 
expectations.

> Allow Xinclude in hadoop config file
> ------------------------------------
>
>                 Key: HADOOP-4944
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4944
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Rama, Ramasamy
>            Assignee: Rama, Ramasamy
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: configInclude2.patch, includes_in_conf.diff.txt
>
>
> It would be easier to mange the configuration of hadoop by allowing include 
> files in configuration file (file: hadoop-site.xml)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to