[
https://issues.apache.org/jira/browse/HADOOP-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667353#action_12667353
]
Tsz Wo (Nicholas), SZE commented on HADOOP-4368:
------------------------------------------------
The patch looks good to me. The only problem I can see is that
FSNamesystem.getStats() should not be declared with "throw IOException"
anymore. Similarly, NameNode.getStats() should not be declared with "throw
IOException".
Some minor suggestions:
- remove getCapacityTotal(), getCapacityUsed(), getCapacityUsedPercent(),
getCapacityUsedNonDFS() and getCapacityRemaining() in FSNamesystem. These
methods are mostly used in a test. All the uses of these methods can be
replaced by getStats().
- deprecated getRawCapacity() and getRawUsed() in DistributedFileSystem and
remove totalRawCapacity() and totalRawUsed() in DFSClient.
It would be great if we can remove DiskStatus instead of deprecated it.
However, it seems we can't because it is public.
Thank you for working on this, Craig.
> Superuser privileges required to do "df"
> ----------------------------------------
>
> Key: HADOOP-4368
> URL: https://issues.apache.org/jira/browse/HADOOP-4368
> Project: Hadoop Core
> Issue Type: Wish
> Components: dfs, libhdfs
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Assignee: Craig Macdonald
> Priority: Minor
> Attachments: fuse_statfs.patch, fuse_statfs_trunk.patch,
> hadoop4368.fsstatus.patch, hadoop4368.fsstatus.v2.patch,
> hadoop4368.fsstatus.v3.patch, hadoop4368.fsstatus.v4.patch,
> hadoop4368.fsstatus.v5.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> super user privileges are required in DFS in order to get the file system
> statistics (FSNamesystem.java, getStats method). This means that when HDFS
> is mounted via fuse-dfs as a non-root user, "df" is going to return
> 16exabytes total and 0 free instead of the correct amount.
> As far as I can tell, there's no need to require super user privileges to see
> the file system size (and historically in Unix, this is not required).
> To fix this, simply comment out the privilege check in the getStats method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
