[ 
https://issues.apache.org/jira/browse/HADOOP-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670211#action_12670211
 ] 

Konstantin Shvachko commented on HADOOP-4045:
---------------------------------------------

I see also that {{incrementCheckpointTime()}} is not called on other occasions, 
like 
- {{EditLog.logEdit()}}
- {{EditLog.close()}}
- {{FSImage.rollFSImage()}}

If we don't increment fsTime for remaining directories, which is done by 
{{incrementCheckpointTime()}}, we risk loosing data on name-node restart. I 
think this is critical enough to be a blocker.


> Increment checkpoint if we see failures in rollEdits
> ----------------------------------------------------
>
>                 Key: HADOOP-4045
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4045
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.19.0
>            Reporter: Lohit Vijayarenu
>
> In _FSEditLog::rollEdits_, if we encounter an error during opening edits.new, 
> we remove  the store directory associated with it. At this point we should 
> also increment checkpoint on all other directories.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to