[
https://issues.apache.org/jira/browse/HADOOP-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671390#action_12671390
]
Tsz Wo (Nicholas), SZE commented on HADOOP-3741:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or
modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of
javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] -1 release audit. The applied patch generated 831 release audit
warnings (more than the trunk's current 827 warnings).
{noformat}
- No new tests added because we do not use unit tests to test web ui.
- findbugs warning:
"org.apache.hadoop.hdfs.server.namenode.status_jsp._jspx_resourceInjector is a
mutable servlet field"
The field is generated by the jsp compiler, not the patch.
- release audit: License header is not added to html and jsp files. It is
consistent with our approach.
> SecondaryNameNode has http server on dfs.secondary.http.address but without
> any contents
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-3741
> URL: https://issues.apache.org/jira/browse/HADOOP-3741
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: Lohit Vijayarenu
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.21.0
>
> Attachments: 3741_20090206.patch, 3741_20090206b.patch,
> SecondaryNameNode web ui.jpg
>
>
> SecondaryNameNode has http server on dfs.secondary.http.address but does not
> have any information on it. It could publish useful information about
> NameNode it is talking to, checkpoints, the current configured checkpoint
> interval and checkpoint size and also configured directories.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
