[
https://issues.apache.org/jira/browse/HADOOP-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675093#action_12675093
]
Hadoop QA commented on HADOOP-5164:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12400457/HADOOP-5164.2.patch
against trunk revision 745705.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 27 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3882/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3882/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3882/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3882/console
This message is automatically generated.
> Subclasses of ClusterMapReduceTestCase can't easily add new configuration
> parameters
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-5164
> URL: https://issues.apache.org/jira/browse/HADOOP-5164
> Project: Hadoop Core
> Issue Type: Bug
> Components: test
> Reporter: George Porter
> Attachments: HADOOP-5164.1.patch, HADOOP-5164.2.patch,
> HADOOP-5164.patch
>
>
> Currently there is not a clean way for subclasses of ClusterMapReduceTestCase
> to add to the JobConf used to start the cluster daemons.
> The startCluster() method does take a Properties object that is added to the
> JobConf used to the start the daemons. However, startCluster() is called
> from JUnit inside the setUp() method, which sets this parameter to be null.
> If you try to override setUp() in a subclass of ClusterMapReduceTestCase,
> then you won't be able to invoke the TestCase.setUp() ancestor without
> calling ClusterMapReduceTestCase's setUp() (which will pass in the null
> parameter). On the other hand, if you just call startCluster() within your
> test method, then you would be starting up a cluster that was already started.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
