[
https://issues.apache.org/jira/browse/HADOOP-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675253#action_12675253
]
Hemanth Yamijala commented on HADOOP-2898:
------------------------------------------
Peeyush, a couple of comments:
- In HadoopCommand, the member variable, hadoopPortRange should be private. So,
by convention, it should be __hadoopPortRange.
- The low and high ports are being printed at an info level in createXml. These
seem like trace statements, hence can be removed, as we know the values are
read properly.
- We have some tests under src/contrib/hod/testing. One of them,
test_createHadoopSiteXml, is failing. The reason is because we've now made
HadoopCommand take an additional argument, the hadoop port range, which is not
being passed from the test case. Please modify the test case. You can verify
that tests are running by running python testing/main.py under the HOD_HOME.
Passing the port range as the default 50000-60000 in the test case should be Ok.
- Under documentation, please move the line item for the new configuration
option under the hodring section, because it is not an option to be configured
under any other section, and hence is not needed for the common configuration
section.
- Also, please change the documentation to read: "Range of ports, among which
an available port shall be picked for use to run a Hadoop service, like
JobTracker or TaskTracker."
> HOD should allow setting MapReduce UI ports within a port range
> ---------------------------------------------------------------
>
> Key: HADOOP-2898
> URL: https://issues.apache.org/jira/browse/HADOOP-2898
> Project: Hadoop Core
> Issue Type: Improvement
> Components: contrib/hod
> Affects Versions: 0.16.0
> Reporter: Luca Telloli
> Assignee: Peeyush Bishnoi
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: hadoop-2898.txt, hadoop-2898v1.txt
>
>
> HOD currently does now allow to explicitly specify ports or a port range in
> the MapReduce and HDFS sections, but this could be useful. A typical example
> would involve firewall settings that allow only a certain range of ports.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
