[
https://issues.apache.org/jira/browse/HADOOP-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Douglas updated HADOOP-5528:
----------------------------------
Status: Open (was: Patch Available)
This is looking good.
* Instead of the Indexer classes, this can use {{(index + key.getLength()) %
key.getLength()}} for both positive and negative values
* The right index should probably default to \-1
* It's fair to assume that a user specifying an offset into binary data is
certain that its length can accommodate it, so the max/min games preventing
exceptions are probably too permissive.
* The semantics as written for the unit tests confuse me. For example, given
{noformat}
x = { 1, 2, 3, 4, 5 };
y = { 6, 2, 3, 7, 8 };
{noformat}
The test asserts that the left, right offsets {{1, -2}} and {{1, 3}} refer to
the same elements, but this seems incorrect, because then {{3, -1}} would not
refer to the last two bytes, but to the same byte. There would be no way to
specify "the last n" bytes because the last byte is unaddressable.
> Binary partitioner
> ------------------
>
> Key: HADOOP-5528
> URL: https://issues.apache.org/jira/browse/HADOOP-5528
> Project: Hadoop Core
> Issue Type: New Feature
> Components: mapred
> Reporter: Klaas Bosteels
> Assignee: Klaas Bosteels
> Attachments: HADOOP-5528.patch, HADOOP-5528.patch, HADOOP-5528.patch,
> HADOOP-5528.patch
>
>
> It would be useful to have a {{BinaryPartitioner}} that partitions
> {{BinaryComparable}} keys by hashing a configurable part of the bytes array
> corresponding to each key.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
