[
https://issues.apache.org/jira/browse/HADOOP-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694572#action_12694572
]
Hadoop QA commented on HADOOP-2413:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12404282/unStatic.patch
against trunk revision 760783.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/89/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/89/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/89/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/89/console
This message is automatically generated.
> Is FSNamesystem.fsNamesystemObject unique?
> ------------------------------------------
>
> Key: HADOOP-2413
> URL: https://issues.apache.org/jira/browse/HADOOP-2413
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.15.1
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Konstantin Shvachko
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: unStatic.patch
>
>
> FSNamesystem is unique in almost all cases but it is not universally true.
> So we should either remove the static variable
> FSNamesystem.fsNamesystemObject or make it final (so that it cannot be
> overwritten).
> When I am working on HADOOP-1298, I use the convenient static method
> FSNamesystem.getFSNamesystem() to get "the" FSNamesystem object. However, it
> keeps failing on TestCheckpoint. Why? It is because TestCheckpoint uses
> NameNode and SecondaryNameNode. Both of them are creating FSNamesystem. So
> FSNamesystem.fsNamesystemObject does not remain constant. The kind of bug is
> hard to be detected.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
