[ 
https://issues.apache.org/jira/browse/HADOOP-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695133#action_12695133
 ] 

Hadoop QA commented on HADOOP-5605:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12404481/reportBadBlock2.patch
  against trunk revision 761407.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/104/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/104/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/104/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/104/console

This message is automatically generated.

> All the replicas incorrectly got marked as corrupt.
> ---------------------------------------------------
>
>                 Key: HADOOP-5605
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5605
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Raghu Angadi
>            Assignee: Hairong Kuang
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: reportBadBlock.patch, reportBadBlock1.patch, 
> reportBadBlock2.patch
>
>
> NameNode does not handle {{reportBadBlocks()}} properly. As a result, when 
> DataNode reports the corruption (only in the case of block transfer between 
> two datanodes), further attempts to replicate the block end up marking all 
> the replicas as corrupt!
> From the implementation, it looks like NN incorrectly uses the block object 
> used in RPC to queue to neededReplication queue instead of using internal 
> block object. 
> will include an actual example in the next comment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to