[
https://issues.apache.org/jira/browse/HADOOP-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696805#action_12696805
]
Doug Cutting commented on HADOOP-5266:
--------------------------------------
Some nits from a cursory glance at the code:
- MarkableIterable lacks javadoc, which as a public interface, is required.
- Does BackupStore need to be public? I can't see why it does.
- Does ReduceContext#backupStore need to be protected, not private?
Should we benchmark this to make sure that it doesn't measurably slow things
even when disabled?
> Values Iterator should support "mark" and "reset"
> -------------------------------------------------
>
> Key: HADOOP-5266
> URL: https://issues.apache.org/jira/browse/HADOOP-5266
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Jothi Padmanabhan
> Assignee: Jothi Padmanabhan
> Fix For: 0.21.0
>
> Attachments: hadoop-5266-v1.patch
>
>
> Some users have expressed interest in having a mark-reset functionality on
> values iterator. Users can call mark() at any point during the iteration
> process and a subsequent reset() should move the iterator to the last value
> emitted when mark() was called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
