[
https://issues.apache.org/jira/browse/HADOOP-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700745#action_12700745
]
Sharad Agarwal commented on HADOOP-5681:
----------------------------------------
sorry for the late comment. One minor thing I noticed while going thru other
(HADOOP-5680 and HADOOP-5797) jiras:
{code}
public int run(String[] args) throws Exception {
if (args.length == 0) {
System.out.println("Usage: writer <out-dir>");
ToolRunner.printGenericCommandUsage(System.out);
System.exit(2);
}
....
{code}
Here instead of System.exit, exit code should be returned. This should also fix
the findbugs warning. I think same applies to HADOOP-5680 and HADOOP-5697
> Change org.apache.hadoop.examples.RandomWriter and
> org.apache.hadoop.examples.RandomTextWriter to use new mapreduce api.
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5681
> URL: https://issues.apache.org/jira/browse/HADOOP-5681
> Project: Hadoop Core
> Issue Type: Sub-task
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.21.0
>
> Attachments: patch-5681-1.txt, patch-5681.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
