[
https://issues.apache.org/jira/browse/HADOOP-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701331#action_12701331
]
Konstantin Shvachko commented on HADOOP-5687:
---------------------------------------------
This looks good to me. 2 minor things.
# There is an empty line change in {{DistributedFileSystem}}. Could you please
remove it.
# Could you please move the declaration of the new constant in {{FSConstants}}
up above the {{LAYOUT_VERSION}} declaration.
We want to keep it last to make it more visible when the layout version needs
to be updated.
Other than that it is ready for Hudson.
> Hadoop NameNode throws NPE if fs.default.name is the default value
> ------------------------------------------------------------------
>
> Key: HADOOP-5687
> URL: https://issues.apache.org/jira/browse/HADOOP-5687
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Philip Zeyliger
> Priority: Minor
> Attachments: HADOOP-5687-v3.patch, HADOOP-5687.patch,
> HADOOP-5687.patch
>
>
> Throwing NPE is confusing; instead, an exception with a useful string
> description could be thrown instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
