[
https://issues.apache.org/jira/browse/HADOOP-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702701#action_12702701
]
Hadoop QA commented on HADOOP-5728:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406234/editlog-printstatistics.patch
against trunk revision 768376.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/241/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/241/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/241/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/241/console
This message is automatically generated.
> FSEditLog.printStatistics may cause IndexOutOfBoundsException
> -------------------------------------------------------------
>
> Key: HADOOP-5728
> URL: https://issues.apache.org/jira/browse/HADOOP-5728
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.1
> Environment: jdk 1.6, centOS 5.2 and hadoop 0.19.1
> Reporter: Wang Xu
> Assignee: Wang Xu
> Fix For: 0.19.2
>
> Attachments: editlog-printstatistics.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> We met IndexOutOfBoundsException exception when did logSync or rollEditlog,
> the direct reason is the printStatistics of FSEditLog used the first element
> of
> StringArray editStreams, but does not check whether editStreams is empty
> when
> it is not null. As below:
> if (editStreams == null ) {
> return;
> }
> .....[snipped]....
> buf.append(" Number of syncs: " + editStreams.get(0).getNumSync());
> the simple solution is to check whether it is empty.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
