[
https://issues.apache.org/jira/browse/HADOOP-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705310#action_12705310
]
Flavio Paiva Junqueira commented on HADOOP-5721:
------------------------------------------------
Thanks for your comments, Konstantin. The patch I uploaded removes all
reformatting modifications from FSEditLog and TestEditLog, and hopefully now
relevant changes are more evident.
The discussion on configuration was triggered when you asked to make
FSEditLog.sizeFlushBuffer a private static field of EditLogFileOutputStream
together with FSEditLog.setBufferCapacity() method. TestEditLog calls
FSEditLog::setBufferCapacity(), so it seems necessary to pass a buffer size to
FSEditLog, in particular because the buffer size value is necessary in the
constructor of EditLogFileOutputStream. In any case, as I said before, I agree
that a more extensive discussion of how to improve the configuration of log
devices belongs in another jira.
I have run tests for this new patch: core tests pass fine and the findbugs
count does not increase. I also believe that the new files are formatted
according to the guidelines.
> Provide EditLogFileInputStream and EditLogFileOutputStream as independent
> classes
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5721
> URL: https://issues.apache.org/jira/browse/HADOOP-5721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.19.1
> Reporter: Luca Telloli
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: HADOOP-5721.patch, HADOOP-5721.patch, HADOOP-5721.patch,
> HADOOP-5721.patch, HADOOP-5721.patch, HADOOP-5721.patch, HADOOP-5721.patch,
> HADOOP-5721.patch
>
>
> EditLogFileInputStream and EditLogFileOutputStream are currently part of
> FSEditLog. With this patch we want to extract them and provide as independent
> classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
