[
https://issues.apache.org/jira/browse/HADOOP-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705976#action_12705976
]
Vinod K V commented on HADOOP-5719:
-----------------------------------
Few comments:
- I think a better place for job removal from the JobQueuesManager is the
cleanUpInitializedJobsList() method of teh JobInitializationPoller. We may want
to rename this method and change its javadoc a bit.
- We don't need the null check before job.fail() in the initialization-poller
- Test-case doesn't compile(perhaps because of HADOOP-5726). Need to change
the signature of FakeQueueInfo
- In the test-case, the statements depicting the error scenarios have to be
reversed. For e.g. at TestCapacityScheduler.java +2045 {code}
assertFalse("Waiting job does not contain submitted job",
mgr.getWaitingJobs("default").contains(job)); {code} should instead be {code}
assertFalse("Waiting job contains submitted job",
mgr.getWaitingJobs("default").contains(job)); {code}
> Jobs failed during job initalization are never removed from Capacity
> Schedulers waiting list
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-5719
> URL: https://issues.apache.org/jira/browse/HADOOP-5719
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: HADOOP-5719-1.patch
>
>
> Jobs which fail during initalization are never removed from Capacity
> Schedulers waiting job list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
