[
https://issues.apache.org/jira/browse/HADOOP-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707591#action_12707591
]
Konstantin Shvachko commented on HADOOP-5721:
---------------------------------------------
- The patch should be regenerated because of the recent test packages
restructuring.
- You forgot to remove {{sizeOutputFlushBuffer}} from
{{EditLogFileOutputStream}}
- In {{EditLogFileOutputStream}} and {{EditLogFileInputStream}} "@Override"
and the comment "// JournalStream" should be on the same line because the
comments clarifies what the override overrides.
+1 other than that.
> Provide EditLogFileInputStream and EditLogFileOutputStream as independent
> classes
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-5721
> URL: https://issues.apache.org/jira/browse/HADOOP-5721
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.19.1
> Reporter: Luca Telloli
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: HADOOP-5721.patch, HADOOP-5721.patch, HADOOP-5721.patch,
> HADOOP-5721.patch, HADOOP-5721.patch, HADOOP-5721.patch, HADOOP-5721.patch,
> HADOOP-5721.patch, HADOOP-5721.patch
>
>
> EditLogFileInputStream and EditLogFileOutputStream are currently part of
> FSEditLog. With this patch we want to extract them and provide as independent
> classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
