[
https://issues.apache.org/jira/browse/HADOOP-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709660#action_12709660
]
Tsz Wo (Nicholas), SZE commented on HADOOP-5842:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
{noformat}
Since the patch fixes syntax related warnings and does not change any logic, I
will commit this without submitting to Hudson for saving some cycles.
> Fix a few javac warnings under packages fs and util
> ---------------------------------------------------
>
> Key: HADOOP-5842
> URL: https://issues.apache.org/jira/browse/HADOOP-5842
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: warnings.patch
>
>
> Fix javac warnings in the following files:
> fs/FileSystem.java
> fs/ChecksumException.java
> fs/FSError.java
> fs/kfs/KFSInputStream.java
> fs/s3/S3FileSystemException.java
> fs/s3/S3Exception.java
> fs/s3/VersionMismatchException.java
> util/ProcfsBasedProcessTree.java
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
