[
https://issues.apache.org/jira/browse/HADOOP-5854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710032#action_12710032
]
Raghu Angadi commented on HADOOP-5854:
--------------------------------------
1. not sure
2. It needs to synchronize since it is going wait on the object. This member is
written so that common case (ready is true) does not need any synchronization.
3. It is under dataQueue lock. findbugs does not detect locks in the callers.
But the problem is that other access in fsync() is under a different lock. It
can't be fixed easily.
> findbugs : fix "Inconsistent Synchronization" warnings in hdfs
> ---------------------------------------------------------------
>
> Key: HADOOP-5854
> URL: https://issues.apache.org/jira/browse/HADOOP-5854
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Fix For: 0.21.0
>
> Attachments: HADOOP-5854.patch
>
>
> This jira fixes the following findbugs warnings :
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.closed; locked 75% of time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.DFSClient$DFSOutputStream.persistBlocks; locked 66% of
> time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.common.UpgradeManager.currentUpgrades; locked
> 61% of time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.common.UpgradeManager.upgradeState; locked 75%
> of time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.namenode.FSDirectory.ready; locked 50% of time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.datanode.DataBlockScanner.verificationLog;
> locked 45% of time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.safeMode; locked 48% of
> time
> * Inconsistent synchronization of
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem$SafeModeInfo.extension;
> locked 80% of time
> * Inconsistent synchronization of
> org.apache.hadoop.io.SequenceFile$Reader.sync; locked 85% of time
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
