[
https://issues.apache.org/jira/browse/HADOOP-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710832#action_12710832
]
Suresh Srinivas commented on HADOOP-5853:
-----------------------------------------
After running the tests again, I do not see eclipse classpath issue. However
the release audit is still being printed. The two new warnings are:
[javadoc] JDiff: warning: change from deprecated to undeprecated for method
FileSystem.isDirectory
[javadoc] JDiff: warning: change from deprecated to undeprecated for method
HttpServer.addInternalServlet
First one comes from a change that was made earlier. The second undeprecation
is the intent of this patch. I propose committing this patch, given the release
audit warning is expected.
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
[exec]
[exec] -1 release audit. The applied patch generated 496 release
audit warnings (more than the trunk's current 494 warnings).
> Undeprecate HttpServer.addInternalServlet method to fix javac warnings
> ----------------------------------------------------------------------
>
> Key: HADOOP-5853
> URL: https://issues.apache.org/jira/browse/HADOOP-5853
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: 5853.patch
>
>
> Deprecated method {{HttpServer.addInternalServlet()}} causes many java
> warnings. Next comment covers the reason for undeprecating the method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
