[
https://issues.apache.org/jira/browse/HADOOP-5873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710946#action_12710946
]
Tsz Wo (Nicholas), SZE commented on HADOOP-5873:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath
integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
{noformat}
Will do manual tests for the web pages.
> Remove deprecated methods randomDataNode() and getDatanodeByIndex(..) in
> FSNamesystem
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-5873
> URL: https://issues.apache.org/jira/browse/HADOOP-5873
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Fix For: 0.21.0
>
> Attachments: 5873_20090519.patch
>
>
> FSNamesystem.randomDataNode() and getDatanodeByIndex(..) can be replaced by
> getRandomDatanode().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
