On Thu, Jun 25, 2009 at 13:04, Xueming Shen <xueming.s...@sun.com> wrote:
> >> yes, it now solved the puzzle:-) > > (1)closeEntry() is not strictly necessary, either putNextEntry or close() > will close the previous entry > (2)you might want to go a little further to "encapsulate" the updateEntry > into crc32os, pass the entry > into the constructor and setup the value with a crc32os.close()...bad idea? > It's somewhat magical to have close to this, and close is not currently called automatically anywhere. explicit updateEntry is at least easy to understand. Martin
