Alan Bateman wrote:
I need a reviewer for a small update so that the os.name property is
set correctly on Windows Server 2008 R2. The webrev is here:
http://cr.openjdk.java.net/~alanb/6843003/webrev.00/
Thanks,
Alan.
The fix itself looks OK.
2 random thoughts
(1)I see lots of
sprops.os_name = "Windows NT (unknown)";
It might be better to simply initialize the sprops.os_name to "Windows
NT (unknown)" at
the very beginning of the nt block and then depends on the version
number to see if we have
a better guess.
(2)We have been doing the same exercise every time MS released a new os,
it might be the
time to extract this out to a "configurable" file and simple do a lookup
based on the platform,
verMajor, verMinor.
Sherman
