As we discussed here, this looks fine.
Brad
On 6/8/2010 8:31 AM, Joe Darcy wrote:
Thanks Martin and Rémi for the quick reviews!
Upon further consideration, before doing the push I decided to look for
instances in the jdk repo where this new constructor could be used and I
found one in java.security.Security:
--- old/src/share/classes/java/security/Security.java 2010-06-08
01:07:48.000000000 -0700
+++ new/src/share/classes/java/security/Security.java 2010-06-08
01:07:48.000000000 -0700
@@ -678,7 +678,7 @@
spiMap.put(type, clazz);
return clazz;
} catch (ClassNotFoundException e) {
- throw (Error)new AssertionError("Spi class not found").initCause(e);
+ throw new AssertionError("Spi class not found", e);
}
}
Security team, please review this change to java.security.Security; the
new code should be operationally equivalent. All the public security
regression tests pass on a build with this change.
Updated full webrev at:
http://cr.openjdk.java.net/~darcy/6935997.1/
Thanks,
-Joe
Rémi Forax wrote:
Le 04/06/2010 09:13, Martin Buchholz a écrit :
Looks good!
Martin
Ok for me too.
Rémi
On Thu, Jun 3, 2010 at 23:58, Joe Darcy<joe.da...@oracle.com> wrote:
Hello.
Please review my fix for
6935997 "Please add a nested throwable constructor to AssertionError"
http://cr.openjdk.java.net/~darcy/6935997.0/
Thanks,
-Joe
