Looks good to me. I did wonder if we have a policy for tracking fdlibm updates. The fdlibm people don't seem to ascribe dates to their releases or think to include version numbers in their headers. Are we using 5.3, the apparent latest version? Their release page mentions an outstanding incorrect code generation bug due to non-standards compliant code. Is our usage vulnerable to this bug? Do we have a test to catch this bug should it be encountered?
Mike On Aug 4 2011, at 11:56 , Joe Darcy wrote: > Hello. > > Please review these straightforward changes for > > 7075098: Remove unused fdlibm files > http://cr.openjdk.java.net/~darcy/7075098.0/ > > The JDK math libraries in java.lang.{Math, StrictMath} do not expose all the > functionality implemented in the embedded copy of FDLIBM (freely > distributable math library). Since we do not plan do expose the remaining > functionality (erf, gamma, lgama, j0, j1, jn, acosh, asinh, etc.) and these > functions are not needed by the Java core libs directly or by transitivity, > this changeset removes the unneeded files from the build. > > On my Linux build, with this change the size of the compiled fdlibm library > file went down from 234,372 to 165,750 and all the math library regression > tests pass. > > Thanks, > > -Joe
