Alan Bateman wrote:
Joe Darcy wrote:
Hi Alan.

I did check for that point in my review :-)

The VirtualMachineError class is abstract so as long as all its subclasses declare a serialVersionUID, like InternalError does, I think we're fine.
We need to check the serialization protocol but I'm pretty the object stream class of the supertype goes into the stream too. Also I quickly checked an an up-to-date build of jdk8/tl and its currently unable to deserialize streams contain any of the virtual machine errors like OutOfMemoryError, StackOverflowError, etc.

*sigh*

Thanks for checking on this Alan; I'll prepare a changeset with the explicit serialVersionUID on InternalError.

-Joe

Reply via email to