On 23/11/2011 19:39, Xueming Shen wrote:
Thanks Alan.
The webrev has been updated accordingly.
http://cr.openjdk.java.net/~sherman/7109837/webrev/
Minor nit but we should probably use {@code null} instead of <tt>null</tt>.
I think the opening sentence "Updates the Adler32 checksum with the
specified ByteBuffer" could be improved, how about: "Updates the
checksum with the bytes from the given buffer". Same thing in CRC32.
Thanks for adding the test to check the buffer position/limit after the
update.
One small concern with the test is that it's a bit of a stress test and
will run for a long time. What you would think about having a -shortrun
option. Look at test/java/util/Arrays/Sorting.java for example where I
dialed down Vladimir's test so that it runs quickly in the test runs but
is more comprehensively when run without any options.
-Alan
