Am 09.12.2011 17:07, schrieb Sean Mullan:
On 12/6/11 3:48 PM, Sebastian Sickelmann wrote:
Am 05.12.2011 19:06, schrieb Sean Mullan:
On 12/2/11 11:02 AM, Sean Mullan wrote:
[0] Solution 1
http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_4/index.html
[1] Solution 2
http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_6/index.html
I definitely prefer solution 2. Just a few minor comments:
- Use the javadoc @inheritDoc tag instead of copying the javadoc for the
initCause method.
- PreventOverridingOfChaining
lines 68, 71: what do these comments mean?
one additional test that would be useful to add would be to call initCause twice
for those ctors that don't have a Throwable parameter, and make sure initCause
throws IllegalStateExc.
--Sean
Updated the webrev[2] to include your review.
[2]
http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_7/index.html
You didn't add the additional test that I thought would be useful - are you
going to add that? Otherwise, it looks good.
--Sean
Sorry, I missed this.
I updated the webrev[3]
[3]
http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/NoSuchMechanismException/7011804_8/index.html
-- Sebastian
