Hello Darryl,

On 1/23/2012 3:19 PM, Darryl Mocek wrote:
Re-sending this with the synopsis in the subject line (and the correct bug #).

Hello core-libs. Please review this patch to fix Bug #7129185. This fix addresses comments made by Jason Mehrens to the commit of the fix for bug #4533691, including adding a Collections.emptyNavigableSet method. Tests are included.

Webrev, can be found here: http://cr.openjdk.java.net/~dmocek/7129185/webrev.00



I recommend using some different javadoc idioms.  For example, I'd replace

3209      * <pre>
3210 * NavigableSet&lt;String&gt; ns = Collections.emptyNavigableSet();
3211      * </pre>


with

<blockquote>
{@code NavigableSet<String> ns = Collections.emptyNavigableSet();}
</blockquote>

and replace <tt>Foo</tt> with {@code Foo}.

-Joe

Reply via email to