Re: Review request : 7141141 Add 3 new test scenarios for testing Main-Class attribute in jar manifest file

[Joe Darcy]

Looks fine,

-Joe

On 2/1/2012 7:47 PM, Kumar Srinivasan wrote:

Hi Joe, David,

Thanks for the feedback, here is the modified delta webrev:

http://cr.openjdk.java.net/~ksrini/7141141/webrev.1/webrev.delta/index.html

Changes are:
* Eliminated typos and fixed the comments
* Replaced @compile with @build
* Replaced Throwable with IOException this makes it consistent.

Thanks
Kumar

Hello,

On 2/1/2012 1:37 PM, Kumar Srinivasan wrote:

Hi,

Here are some improvements to the launcher tests, contributed by Sonali
Goel of the SQE team, please review:

http://cr.openjdk.java.net/~ksrini/7141141/webrev.0/

The CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141141

Thanks
Kumar

A few stylistic comments:

29  * @compile -XDignore.symbol.file MainClassAttributeTest.java

It might suffice to use @build instead of @compile.

43 * only English is seleced and will pass vacuosly for other locales.

  44  *
  45  */

Extra line.

  98     public static void main(String[] args) throws Throwable {

Is it necessary to throw Throwable here?

Otherwise looks fine.

-Joe