On Apr 17, 2012, at 11:50 AM, Alan Bateman wrote: > On 16/04/2012 17:55, Paul Sandoz wrote: >> Hi, >> >> I ain't got permission to publish webrevs yet. So attached is a patch >> produced by hg export on the jdk tree for: >> >> 7157656 (zipfs) SeekableByteChannel to entry in zip file always reports >> its position as 0 >> >> Paul. > Sherman wrote this zip provider and I assume will want to review this so I'll > leave it to him. >
OK. Managed to push a webrev: http://cr.openjdk.java.net/~psandoz/7157656/webrev.0/ proxy issues... > One thing I notice, and nothing to do with your patch, is that the > position(long) method is missing an implementation, it shouldn't throw UOE. There is a comment: // sbc.position(pos) is not supported in current version in the test code. I put test checks in place, mainly to be consistent, rather than any foresight on my part. > Also for the append case it looks like read throws UOE whereas it should > throw NonReadableChannelException. > OK. What about the methods: position & truncate? I will let Sherman comment as appropriate. Sherman, i can fix if you like. Paul.
