Hi Lance,
Did you review the patch and compare it to yours. I just have some more
words for the patch.
1. I think the current spec for free() is not clear, how about add below
comments:
After free has been called, any attempt to invoke a method other
than free will result in a SerialException being thrown.
2. getBinaryStream(long pos,long length)
add a javadoc:
* @throws SerialException if this SerialBlob already be freed.
add throws SerialException from this method
Any suggestions?
Thanks a lot!
On 07/02/2012 06:25 PM, Lance Andersen - Oracle wrote:
Hi Deven,
Thanks for the email and the proposed patch. I will look at this
later today or tomorrow. I actually have made these changes in my
workspace for JDK 8 but will compare your changes to mine.
Best
Lance
On Jul 2, 2012, at 5:04 AM, Deven You wrote:
Hi All,
Could anyone notice this problem?
Thanks a lot!
On 06/25/2012 04:18 PM, Deven You wrote:
Hi All,
First of all, if the jdbc problem has a better mailing list to post
please tell me.
I find that javax.sql.rowset.serial.SerialBlob is not fully
implemented in OpenJDK 8. Methods
public InputStream getBinaryStream(long pos,long length) throws
SQLException
public void free() throws SQLException
only throw UnsupportedOperationException.
I have made a patch[1] to implement these 2 methods. Could anyone
take a look to review it.
BTW: I think the spec for SerialBlob is not very clear like it
doesn't mention if all method rather than free() need throw any
exception after free() is invoked. However that behavior seems
reasonable.
[1] http://cr.openjdk.java.net/~littlee/OJDK-576/webrev
<http://cr.openjdk.java.net/%7Elittlee/OJDK-576/webrev>
Thanks a lot.
--
Best Regards,
Deven
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
--
Best Regards,
Deven
