Hi Chris,
You can count me as a reviewer anyway. :)
A couple of observations:
--- old/src/share/classes/java/util/concurrent/ExecutionException.java
Thu Oct 25 14:14:15 2012
+++ new/src/share/classes/java/util/concurrent/ExecutionException.java
Thu Oct 25 14:14:14 2012
@@ -79,11 +79,9 @@
/**
* Constructs an <tt>ExecutionException</tt> with the specified cause.
- * The detail message is set to:
- * <pre>
- * (cause == null ? null : cause.toString())</pre>
- * (which typically contains the class and detail message of
- * <tt>cause</tt>).
+ * The detail message is set to {@code (cause == null ? null :
+ * cause.toString())} (which typically contains the class and
+ * detail message of <tt>cause</tt>).
The last <tt>cause</tt> should be replaced by {@Code cause}.
There are a couple of places that refer to JLS (eg package-info, Locks.java)
+ * <a href="http://java.sun.com/docs/books/jls/";> The Java Language
+ * Specification, Third Edition (17.4 Memory Model)</a>:
which should, I believe, be updated to:
http://docs.oracle.com/javase/specs/jls/se7/html/index.html
Thanks,
David
On 26/10/2012 12:13 AM, Chris Hegarty wrote:
In preparation to a re-sync of the java.util.concurrent classes with
Doug's CVS, I've extracted most of the minor/small changes. This will
reduce the noise when reviewing the remainder of the implementation
changes. More specifically,
Cleanup:
javadoc style/consistency
javadoc example code style
imports
whitespace
uniform serialization method javadoc
typos
Minor/small impl changes:
remove redundant null checks
throw NPE when more efficient
rework timeouts, lasttime -> deadline
STPE, make drainTo methods more robust when add throws
To be clear, I'm not requested a review here. These are Doug's changes
are I am already a reviewer, but please feel free ( be warned, nothing
interesting here! )
http://cr.openjdk.java.net/~chegar/8001575/webrev.00/webrev/
-Chris.
