Thumbs up.

Mandy

On 1/3/2013 4:13 AM, Chris Hegarty wrote:
This test fails on all platforms since the integration of 8004727: "Add compiler support for parameter reflection".

The test fails to compile a dependent class tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java:
  AttributeVisitor is not abstract and does not override abstract method
  visitMethodParameters(MethodParameters_attribute,Element) in Visitor
  class AttributeVisitor implements Attribute.Visitor<Element, Element>

8004727 added visitMethodParameters(MethodParameters_attribute attr, P p) to class Attribute.Visitor, and AttributeVisitor, concrete implementation of an Attribute.Visitor defined in ClassReader.java, needs to correctly implement it.

I would like to add tools/pack200/AttributeTests.java to the ProblemList.txt until the issues with the test can be resolved. This will most likely be done through 8005252, "pack200 should support MethodParameters"


hg diff test/ProblemList.txt
diff -r 38b9a7646093 test/ProblemList.txt
--- a/test/ProblemList.txt      Tue Jan 01 17:49:22 2013 -0800
+++ b/test/ProblemList.txt      Thu Jan 03 11:54:43 2013 +0000
@@ -324,6 +324,9 @@ tools/pack200/Pack200Test.java
 # 7150569
tools/launcher/UnicodeTest.java macosx-all

+# 8005252
+tools/pack200/AttributeTests.java generic-all
+

############################################################################


-Chris.

Reply via email to