On 02/14/2013 02:32 AM, Martin Buchholz wrote:

+#if defined(__GNUC__) && (__GNUC__ > 4) || (__GNUC__ == 4) &&
(__GNUC_MINOR__ > 2)
+  #define JNIEXPORT     __attribute__((visibility("default")))
+  #define JNIIMPORT     __attribute__((visibility("default")))

The default compiler in Xcode 4.1 is llvm-gcc 4.2, it seems. The conditional above excludes that. Is this intentional?

If Xcode 4.1 supports visibility properly, you can drop the comparisons because the minimum GCC version on other architectures is already 4.3. (And that's from an outdated README-builds.html—we might require a more recent version in practice.)

--
Florian Weimer / Red Hat Product Security Team

Reply via email to