Thanks! On 19 mar 2013, at 08:51, Alan Bateman <alan.bate...@oracle.com> wrote:
> > I see Serguei has reviewed this. It looks okay to me too. > > -Alan. > > On 18/03/2013 14:14, Staffan Larsen wrote: >> I still need an official Review for this change. >> >> Thanks, >> Staffan >> >> On 7 mar 2013, at 09:10, Staffan Larsen<staffan.lar...@oracle.com> wrote: >> >>> Adding core-libs-dev and re-asking for a review. >>> >>> Thanks, >>> /Staffan >>> >>> On 27 feb 2013, at 15:59, Staffan Larsen<staffan.lar...@oracle.com> wrote: >>> >>>> Please review the following test fix. >>>> >>>> webrev: http://cr.openjdk.java.net/~sla/8006637/webrev.00/ >>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006637 >>>> >>>> The problem is that the test assumes that no other threads call >>>> String.intern() while the tests is running. This is normally ok, but when >>>> running with JFR there are other threads calling String.intern() in the >>>> background and the test fails. The solution is to add a thread filter to >>>> the method exit requests so that only calls to String.inter() in the main >>>> thread are reported. >>>> >>>> Thanks, >>>> /Staffan >
