On 07/03/2013 11:54, Staffan Larsen wrote:
Here is a webrev for fixing this problem. I actually removed all of our own
tokenization code in dll_build_name() and replaced it with calls to strtok_r
(strtok_s on windows) instead. I think this should be more robust, at the cost
of an extra memory allocation. I've also added the const qualifier to some of
the parameters.
http://cr.openjdk.java.net/~sla/8009558/webrev.02/
All of the jdi and hprof tests passes with this change.
Thanks,
/Staffan
This looks good to me too.
A minor nit is that probably should put a space in "while(path = ..." in
all of the dll_build_name implementation. Ignore this comment if you've
already created the change-set are ready to push of course.
-Alan
