Am 12.04.2013 23:36, schrieb Mike Duigou:
On Apr 11 2013, at 15:15 , Ulf Zibis wrote:
There is still a yoda style in ConcurrentMap line 72, HashMap line 361
Fixed
I still see no change in webrev 5 in HashMap line 361
To be in line with old habits, please remove space after casts. See also:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6939278
I am not going to do this.
Well in Hashtable, existing code doesn't have the space after cast. If you insert space in new code,
you introduce an inconsistency in style. Even your new code is inconsistent, compare:
HashTable line 917, 938, 984 etc.
HashMap line 588 etc.
Collections line 1402 etc.
I also notice, you introduce a new style ? in for( ; ... ; ... ;) expressions
with space before ';'.
Collections:
lines 1442... + 3900... , indentation for follow up line should be 8
There are still lines 976, 1062
Map:
lines 599..600 bad indentation
Corrected.
Hm, I see still 3 instead 4 spaces and also in lines 545..546
Use consistent formatted code examples in javadoc. I like the style from lines
567 to 570, but e.g. from line 622 to 626:
- 2 spaces before <pre>
- indentation should be 4
- line break before }</pre>
I had left these along in the previous round. Should be fixed now.
Great, but see also code samples in ConcurrentMap.
-Ulf
