Re: RFR 8012681: Commit for JDK-8012656 breaks tl build Was: can't build current jdk8/tl tip

[Joel Borggrén-Franck]

Fix pushed, thanks for the reviews.

Peter, I missed your patch. My fix should probably have been attributed to 
you, sorry!

cheers
/Joel

On 04/19/2013 10:49 AM, Joel Borggrén-Franck wrote:
Hi

On 04/19/2013 09:30 AM, Alan Bateman wrote:> On 19/04/2013 08:08, Peter
Levart wrote:
 >> Hi,
 >>
 >> I get the following compile-time error:
 >>
 >>
/home/peter/work/hg/jdk8-tl/langtools/src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java:264:

 >> error: illegal start of expression
 >>         if (qualifiedName == null) }
 > I'm seeing the same thing, looks like the typo crept in with this change
 > last night:
 >
 > http://hg.openjdk.java.net/jdk8/tl/langtools/rev/95d29b99e5b3
 >

See inline patch to fix this. Since TL isn't building I think we can review
this on core-libs-dev although technically a compiler issue.

With this fix langtools builds and all langtools tests passes.

cheers
/Joel

diff --git a/src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java
b/src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java
--- a/src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java
+++ b/src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java
@@ -261,7 +261,7 @@
      private String name;

      public String qualifiedName() {
-        if (qualifiedName == null) }
+        if (qualifiedName == null) {
              qualifiedName = sym.enclClass().getQualifiedName() + "." +
name();
          }
          return qualifiedName;