On 23/04/2013 12:17, Alan Bateman wrote:
On 22/04/2013 20:45, Martin Buchholz wrote:
Another preliminary webrev is out at
http://cr.openjdk.java.net/~martin/webrevs/openjdk8/getChars/
<http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk8/getChars/>
Alan et al: Before continuing, can we:
Have thumbs up on the changes to out of bounds exceptions?
I looked over the bound checking. The only one that isn't clear is
AbstractStringBuilder.insert where dstOffset is specified to be
greater than this.length rather than count.
One other observation, but as the 2-arg getChars doesn't have explicit
bounds checking then it may have have copied some chars into the
destination array before it throws the AIOOBE. Not too interesting of
course but it may be worth considering a check before copying.
-Alan.
