This is good to go. Also reviewed by Russ Gold from the Corba team Best Lance On Apr 12, 2013, at 6:48 AM, Dmeetry Degrave wrote:
> > Hi all, > > I'm looking for a review for two ancient issues in idlj. > > First is an issue with uncompilable java code generated for unions with > boolean discriminator. > > 4504275: CORBA boolean type unions do not generate compilable code from idlj > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4504275 > fix: http://cr.openjdk.java.net/~dmeetry/4504275/webrev.0/ > > Second (is not available on bugs.sun.com atm) is an issue with generated > read/write union helper methods that throw org.omg.CORBA.BAD_OPERATION in > cases when boolean discriminator's value isn't matched, which is wrong. > > 8011986: [corba] idlj generates read/write union helper methods that throw > wrong exception in some cases > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011986 > fix: http://cr.openjdk.java.net/~dmeetry/8011986/webrev.0/ > > Both fixes are intended for jdk7 and 8. > > thanks, > dmeetry
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
