Re: RFR: 8009389: Unpack200 native library should be removed from profiles

[Kumar Srinivasan]

Hi David,
Good point, I have made the changes, here is the updated webrev:

http://cr.openjdk.java.net/~ksrini/8009389/webrev.1/

delta webrev to last change:
http://cr.openjdk.java.net/~ksrini/8009389/webrev.1/webrev.delta/index.html

Thanks
Kumar

Hi Kumar,

On 30/04/2013 8:05 AM, Kumar Srinivasan wrote:

Hi,

Please review this fix which will enable profiles and embedded distros to

eliminate the unpack200 binaries saving space, all this does is switch
to the java implementation if the native one cannot be found.

http://cr.openjdk.java.net/~ksrini/8009389/webrev.0/

Minor nit: why the duplicate code instead of having only the unpack in the try-catch:

              } else {
+                 try {
                      (new NativeUnpack(this)).run(in0, out);
+                 } catch (UnsatisfiedLinkError ule) {
+                     // failover to java implementation
+                     (new DoUnpack()).run(in0, out);
                  }
                  in0.close();
                  Utils.markJarFile(out);
+             }

Thanks,
david

Thanks
Kumar