Hi,
Please find an updated webrev below:
<http://cr.openjdk.java.net/~dfuchs/JDK-8008738/webrev.03/>
Changes are:
catch IAE are removed - as suggested by Alan.
I didn't find traces of IAE being thrown by OutputStreamWriter
constructor in recent JDK - so I think it's safe to remove
those catch clauses.
changes in test Makefile have been removed: I rebased my patch on
jdk8 tip, which already has these test Makefile changes.
best regards,
-- daniel
On 4/30/13 11:18 AM, Alan Bateman wrote:
On 15/04/2013 15:09, Daniel Fuchs wrote:
Hi,
This a fix for:
JDK-8008738 - Issue in
com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK
tests to fail intermittently.
<http://cr.openjdk.java.net/~dfuchs/JDK-8008738/webrev.02/>
I skimmed over the webrev and it looks reasonable to me.
In getWriter then I don't understand the "java 1.1.8" comment, I wonder
if the catching of IAE should just be removed.
For jdk_other in the test Makefile then it might be simpler to just add
javax/xml and drop the existing soap and ws directories. I suggest this
because there are only a tiny number of JAXP and JAX-WS tests in the jdk
repo and they are all run via the jdk_other target.
-Alan
