On Friday 03 May 2013 11:53 AM, Tim Bell wrote:
On 05/ 2/13 01:24 PM, I wrote:
Hi Sundar:
Oracle JDK includes Rhino based javax.script implementation (which
lives mostly in "closed" code). Rhino is being removed from Oracle
JDK builds and there are the changes to the jdk open repository as
well like com.sun.script.javascript package, makefiles etc. Please
review the open jdk changes here:
http://cr.openjdk.java.net/~sundar/8012975/
This looks good. Approved.
Tim
Sundar - we have had some breakage in the build forest recently, so to
be extra careful I created a forest and then added your changes. I
also did some blasting away with 'find ... -print | xargs egrep ...'
commands to look for traces of rhino or javascript.
I think you need to look at removing these files as well:
jdk/make/com/sun/script/Makefile
jdk/make/sun/org/mozilla/javascript/Makefile
Tim
Thanks. Looks like the first one has not been removed. But second one
was removed: hg stat shows
R make/sun/org/mozilla/javascript/Makefile
(also the webrev shows it as removed). Perhaps patch does not take care
of deleted files?? I am not sure. Also, build seems to go through
without removing first one!!
I'll remove that, build/test again and send another webrev.
Thanks
-Sundar
