Looks good.

You could optimize it a bit by not doing the Arrays.asList() on every 
methodExit event.

/Staffan

On 17 apr 2013, at 15:03, Mikael Auno <mikael.a...@oracle.com> wrote:

> Hi, I'd like some reviews on 
> http://cr.openjdk.java.net/~nloodin/8009681/webrev.01/ for JDK-8009681 
> (http://bugs.sun.com/view_bug.do?bug_id=8009681).
> 
> The issue here is that when MethodExitReturnValuesTest hooks into MethodExit 
> events through JDI it uses an exclude list to filter out classes from which 
> it is not interested in these events. This is bound to break over and over 
> again as new features are added to the JDK. I've changed the test to use an 
> include list instead, containing only the handful of classes the test is 
> actually interested in.
> 
> Thanks,
> Mikael

Reply via email to