On Jun 11, 2013, at 1:47 AM, Aleksey Shipilev <aleksey.shipi...@oracle.com> wrote:
> On 06/11/2013 02:52 AM, Christian Thalinger wrote: >> This looks good to me. > > Thanks for the review! > >> Could you run RegExp with Nashorn again with and without your changes? > > Being single-threaded, the benchmark will not show much of the > improvement. Also, the results are rather flaky. > > Before: > 1 thread: 175 +- 5 > 2 threads: 199 +- 5 msec/op > > After: > 1 thread: 177 +- 6 msec/op > 2 threads: 189 +- 6 msec/op Thanks for this but I was thinking running it with -Xprof to see whether some of the table methods show up on the profile. -- Chris > > -Aleksey.