So I am going to try to please everybody (I hope).
I agree with Alan Eliasen that the existing patch for 4641897 should be
integrated as-is.
I also think however that we might as well integrate Aleksey and Dima's patch
immediately thereafter, before the large integer division review. To that end I
am creating a separate issue and RFR which I will post today. It would be good
if any other interested parties were to review it.
Thanks,
Brian
On Jun 24, 2013, at 4:17 AM, Alan Bateman wrote:
> "static synchronized" always jumps out but since every toString uses it when
> beyond the threshold then it would be good to eliminate. You're doing great
> work to sequence all these patches and if fixing this now delays the plan
> then it would be fine to address it later.
On Jun 22, 2013, at 8:41 PM, Dmitry Nadezhin wrote:
> Sorry, I missed line "pc[radix] = cacheLine;" in the method
> "getRadixConversionCache();"
> in the previous post.
> Here is the corrected patch.
On Jun 22, 2013, at 4:59 AM, Dmitry Nadezhin wrote:
> Thank you, Aleksey!
>
> Alan said: "I'm willing to review any rewrites that people might suggest".
>
> Here is a concretization of Aleksey's patch for Alan's review.
On Jun 22, 2013, at 3:54 AM, Aleksey Shipilev wrote:
> Of course, there is a series of typos. Should instead be:
>
> T get(int index1, index2) {
> […]
> return lt[index2];
> }
On Jun 21, 2013, at 9:37 PM, Alan Eliasen wrote:
>> Or should it be filed as another bug ?
>
> I'd file it as another bug.
