Hi Lance, I looked through the patch and it looks fine; thanks,
-Joe On 06/27/2013 09:56 AM, Lance Andersen wrote:
Hi all, Need a reviewer for 8017471 which addresses the JDBC doclint errors The webrev can be found at http://cr.openjdk.java.net/~lancea/8017471/webrev.00/ please note that for the WebRowset changes, you will need to use the udiff vs the sdiff formant as webrev generates errors due to the number of changes: ---------------------- src/share/classes/javax/sql/rowset/WebRowSet.java patch cdiffs udiffs/usr/bin/awk: limited to 50 pat,pat statements at source line 74 source file /tmp/64799.file1 context is NR==374,NR==377 >>> {changed();next} <<< /usr/bin/awk: limited to 50 pat,pat statements at source line 75 source file /tmp/64799.file1 /usr/bin/awk: limited to 50 pat,pat statements at source line 76 source file /tmp/64799.file1 /usr/bin/awk: limited to 50 pat,pat statements at source line 75 source file /tmp/64799.file2 ---------------------- Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com